Add CNAME blocking states and show more details in CNAME blocking #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EX_CNAME, QUERY_BLACKLIST_CNAME] and show domain that was the reason for blocking during a CNAME inspection Signed-off-by: DL6ER <dl6er@dl6er.de>
5 tasks
…e with specifying the domainid as GET parameter. Signed-off-by: DL6ER <dl6er@dl6er.de>
…uch as blocked CNAMEs) Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/CNAME_inspection_details
branch
4 times, most recently
from
cb3ca53
to
d638b45
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/CNAME_inspection_details
branch
4 times, most recently
from
5140006
to
a45d3d4
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
force-pushed
the
new/CNAME_inspection_details
branch
from
a45d3d4
to
249dfc7
Compare
PromoFaux
approved these changes
Feb 8, 2020
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/request-show-regex-responsible-for-blocking/27656/30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Implement support for new CNAME-related blocking modes signaling that something was blocked "under the surface" of a query
Show domain that was the actual reason for blocking in case we blocked as a result of a deep CNAME inspection
How does this PR accomplish the above?:
Display new information passed in from pi-hole/FTL#685
What documentation changes (if any) are needed to support this PR?:
None